[api] Add new /content_summary public api #3620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjornalm
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
Looks good to me, but I just want to hear what @Harshg999 and @JohanAhlen thinks of the _normalize_path before we merge
Harshg999
reviewed
Feb 13, 2024
JohanAhlen
reviewed
Feb 20, 2024
| response['summary'] = stats.summary | ||
| except WebHdfsException as e: | ||
| raise Exception(_('Failed to fetch content summary for "%s". ') % path) |
There was a problem hiding this comment.
You should log e (especially e.message)
There was a problem hiding this comment.
The exception (all cascading calls too) will get added in stack trace when the exception occurs. @JohanAhlen - Should we add a better log message separately?
nidhibhatg
force-pushed
the
nidhi_summary_api
branch
2 times, most recently
from
837f63c
to
adac138
Compare
Harshg999
reviewed
Mar 1, 2024
| def content_summary(request, path): | ||
| path = _normalize_path(path) | ||
| response = {'summary': None} |
There was a problem hiding this comment.
I'm now thinking we don't need to set it here. What if for all bad cases response is {} but for the good cases we send response = {'summary': summary}. (line 150)
Looks a bit more cleaner to handle in the UI, what do you think?
|
|
||
| if not path: | ||
| raise Exception(_('Path parameter is required to fetch content summary')) |
nidhibhatg
force-pushed
the
nidhi_summary_api
branch
from
adac138
to
1add954
Compare
athithyaaselvam
pushed a commit
that referenced
this pull request
Jun 10, 2024
* [api] Add new /content_summary public api (cherry picked from commit 55ab28d) (cherry picked from commit bce57833b09cb018419cb700af9940bd2ea917f6) Change-Id: I56732633cc044f4750248ee482a8acd2180ac7b3 (cherry picked from commit 84322ed2bf17133db8904f434e195a79f72ee424)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
How was this patch tested?
Please review Hue Contributing Guide before opening a pull request.